[Freeciv-Dev] Re: [PATCH] Improvement effect definitions (PR#1104)

[jdorje@xxxxxxxxxxxxxxxxxxxxx]

Ben Webb wrote:

> 	The attached patch is the first part of the generalised 
> improvements code from FreecivAC. It defines a number of structures and 
> types in common/improvement.h used to keep track of any effects conferred 
> by city improvements, and adds code to the relevant startup and shutdown 
> routines to initialise and free these effect lists. This in itself doesn't 
> really "do" anything, but shouldn't break any existing code, and is 
> required for the actual implementation of these effects (to follow in 
> later patches).
> Testing would be appreciated...

civclient: climisc.c:1042: renumber_island_impr_effect: Assertion 
`pplayer->island_improv' failed.


(gdb) bt
#0  0x403268d1 in __kill () from /lib/libc.so.6
#1  0x4032664d in raise (sig=6) at ../sysdeps/posix/raise.c:27
#2  0x40327cb8 in abort () at ../sysdeps/generic/abort.c:88
#3  0x4031fd71 in __assert_fail (assertion=0x80beba2 
"pplayer->island_improv", file=0x80be8d1 "climisc.c", line=1042, 
function=0x80beb86 "renumber_island_impr_effect")
    at assert.c:74
#4  0x0806178f in renumber_island_impr_effect (old=24, new=8) at 
climisc.c:1042
#5  0x0805fc2e in climap_renumber_continent (x=25, y=0, newnumber=8) at 
climisc.c:220
#6  0x0805fe58 in climap_update_continents (x=24, y=0) at climisc.c:260
#7  0x0806acc5 in handle_tile_info (packet=0x828f7f8) at packhand.c:1477
#8  0x0805f34d in handle_packet_input (packet=0x828f7f8 "\030", type=7) 
at civclient.c:230
#9  0x08061dcf in input_from_server (fid=6) at clinet.c:330
#10 0x4018be7d in gdk_io_invoke (source=0x8225ac8, condition=G_IO_IN, 
data=0x822f710) at gdkevents.c:882
#11 0x401baa7a in g_io_unix_dispatch (source_data=0x8225ae0, 
current_time=0xbffff810, user_data=0x822f710) at giounix.c:137
#12 0x401bc055 in g_main_dispatch (dispatch_time=0xbffff810) at gmain.c:656
#13 0x401bc659 in g_main_iterate (block=1, dispatch=1) at gmain.c:877
#14 0x401bc7e8 in g_main_run (loop=0x82023c8) at gmain.c:935
#15 0x400d927b in gtk_main () at gtkmain.c:524
#16 0x08087ef2 in ui_main (argc=3, argv=0xbffff954) at gui_main.c:836
#17 0x0805f2b8 in main (argc=3, argv=0xbffff954) at civclient.c:189
#18 0x40314306 in __libc_start_main (main=0x805ee60 <main>, argc=3, 
ubp_av=0xbffff954, init=0x805c78c <_init>, fini=0x80bb5b0 <_fini>, 
rtld_fini=0x4000d2cc <_dl_fini>,
    stack_end=0xbffff94c) at ../sysdeps/generic/libc-start.c:129

Before you ask, I was just using this one patch (on current CVS).

jason