[Freeciv-Dev] Re: Reproducable core dump (PR#1051)

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Sat, Dec 01, 2001 at 01:28:16PM -0800, jdorje@xxxxxxxxxxxxxxxxxxxxx wrote:
> Gregory Berkolaiko wrote:
> 
> > Hi Jason,
> > 
> > I think the patch is ready.  I have few comments on the comments but they
> > shouldn't stand in the way of the acception.
> 
> 
> Here's a fifth and hopefully final version.
> 
> Changes:
> 
> - Declared airspace_looks_usable static and prototyped it.
> 
> - Added comment about ai_handicap.  It's unnecessarily verbose, but 
> should prevent future misunderstandings.
> 
> - Changed comments/freelog as GB suggested.
> 
> - Added a new comment into find_the_shortest_patch suggesting that it 
> use airspace_looks_usable.  This is really GB's domain, I think, I just 
> didn't want it to be forgotten about.

And another version. Changes:
 - unified "safe", "empty" and "usable" to "safe"
 - various changes in comments
 - style changes (extra {} and such)

I now understand and like the function ;)

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 checking for the vaidity of the Maxwell laws on this machine... ok
 checking if e=mc^2... ok
 checking if we can safely swap on /dev/fd0... yes
    -- kvirc 2.0.0's configure

air_goto-6.diff
Description: Text document