[Freeciv-Dev] Re: Please vote!

[Kevin Brown <kevin@xxxxxxxxxxxxxx>]

Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> wrote:
> On Fri, Nov 30, 2001 at 10:25:00PM -0500, Ross W. Wetmore wrote:
> > These sorts of restrictions or differentiations are largely a
> > waste of time, and in only one case is there any real technical
> > coding implication or possible benefit :-).
> 
> But what should I do if people submit changes which change the style
> of the code? Follow the style of the submitter (accept the patch),
> require my personal style (bad) or see if the changes follow the style
> guide? The latter is also objective.

Use indent and be done with it!  If you don't like the style of the
comments or something that indent won't touch, then feel free to
change them.  If enough people don't like your changes they'll bitch
about it and you can either revert your changes or accept their
patches.

But you should mess with the submitter's comments only if you find
those comments truly difficult to read.

What I'm trying to say here is that you should waste as little time as
you can on the formatting when you have a tool (indent) to take care
of it for you anyway.  Those things that indent can't automatically
take care of (like, perhaps, certain comments) are the only things you
should pay any attention to.  Otherwise you're just wasting your time,
and fewer patches will end up being accepted into the source tree.


-- 
Kevin Brown                                           kevin@xxxxxxxxxxxxxx

    It's really hard to define what "unexpected behavior" means when you're
                       talking about Windows.