[Freeciv-Dev] Re: Minor translation patch for citydialog

["Pieter J. Kersten" <kersten@xxxxxxxxxx>]

In reply on my own mail:

On Fri, 2 Nov 2001, Pieter J. Kersten wrote:

> On Thu, 1 Nov 2001, Mike Kaufman wrote:
>
> > On Thu, Nov 01, 2001 at 04:06:28PM +0100, Pieter J. Kersten wrote:
> > > > >
> > > > > Another thing: it seems that on the happiness page world wonders are 
> > > > > never
> > > > > mentioned, even in cities that have them. A bug?
> > > >
> > > > happiness_dialog_update_wonders() only displays wonders that contribute
> > > > to happiness. B_HANGING B_BACH B_SHAKESPEARE B_CURE are them right now
> > > > (AFAIK) and they only appear if city_affected_by_wonder() returns true.
> > > >
> > >
> > > What about Michelangelo's Chapel?
> >
> > I knew after I sent this that I should have said something about the
> > chapel. It should appear in the buildings row. if your city already has
> > a cathedral, it doesn't show up, but if it doesn't it ought to say
> > something like "Cathedral (Michelangelo's Chapel)" since the chapel
> > duplicates a building.
> >
>
> Ok, it does.
>

Reasoning in the same line: what about the Oracle wonder? In the current
implementation it is never shown, although it clearly affects happiness.
Should it show up in the wonders line or in the optional temple
improvement or both?

> > Is what's happening for you? Maybe this isn't intuitive behavior.
> > Perhaps it should appear in both places? The relevant code is at
> > happiness.c:319
> >
>
> Obviously, for me it is more intuitive to have it at both places :-)
>

Ok, I've made a patch to show Michelangelo's Chapel as a wonder, but I'm
hesitating releasing it because of the 'line wrap hack' in that area.
What about that? Why after the second wonder and not after the last?

For the whole function: Can't you make a loop for this? It all seems
identical code besides the B_xxx constants. It should make things a lot
clearer.

> CU,
>

-- 
Pieter J. Kersten