[Freeciv-Dev] Re: [Patch] CMA 2.6 Regarding previous version
[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
On Fri, Oct 19, 2001 at 07:33:41AM -0700, Raahul Kumar wrote:
>
> --- Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> wrote:
>
> > >
> > > The user interface for 2.5 could be improved. Currently we have far too
> > many
> > > options on the left side of the screen, i.e
> > >
> > > max food,trade, prod
> > > max trade,food, prod
> > > max prod,trade, food
> > >
> > > It might be better to replace these elements with 3 drop down boxes. In
> > fact
> > > perhaps the entire left hand side options could be replaced if the boxes
> > have
> > > nothing as an option so for example
> > >
> > > Box 1 food Box2 trade Box3 nothing
> > >
> > > The above example would result in max food, max trade
> > >
> > > All boxes give you four options, max food, trade,prod, or nothing, so with
> > > these
> > > three boxes you could replace the entire left hand side. Comments?
> >
> > There are 6 attributes (food, prod, trade, science, gold, luxury). So
> > there would be 6 boxes with 6 elements on the dropdown list. So I
> > think this is not a good idea.
> >
> > What would be a good idea IMHO is to let the user create/modify the
> > preset values.
>
>
> Yes I think so too. Text file or graphical or perhaps both? But my
> suggestion was just an attempt to simplify.
If a game is started these preset values can be saved in
attributes. However the user may want to have some user preset at the
game start. These can be achieved via .civclientrc.
> > > The sliders for the surplus needs are good, but the ability to make
> > > a surplus an arbitrary negative is not necessary.
> >
> > I know but I don't know a way to wrap the slider, so that you have "no
> > limit",0,1,...,25.
> >
>
>
> There's probably someone on the mailist list who does know. Give them a try.
>
> +#define DEBUG_REQUEST_IDS 0
> +#define DEBUG_TODO_LISTS 0
> +#define META_CALLBACKS_LOGLEVEL LOG_DEBUG
> +#define PRINT_STATS_LOGLEVEL LOG_DEBUG
> +#define DEBUG_FREEZE 0
> +#define MAX_AGENTS 10
>
>
> #define CALC_FITNESS_LOG_LEVEL LOG_DEBUG
> +#define CALC_FITNESS_LOG_LEVEL2 LOG_DEBUG
> +#define EXPAND_CACHE3_LOG_LEVEL LOG_DEBUG
> +
> +#define SHOW_EXPAND_CACHE3_RESULT 0
> +#define SHOW_CACHE_STATS 0
> +#define SHOW_TIME_STATS 0
> +#define DISABLE_CACHE3 0
> +#define ALWAYS_APPLY_AT_SERVER 0
> +
>
> #define GOLD 3
> +#define LUXURY 4
> +#define SCIENCE 5
>
> Formatting problems, the constants look better if everything is in line,
> instead of having LOG_DEBUG hanging off to the right. Same applies to the 5.
I will do an indent run.
> Tell me more about the freeze and thaw functions. It looks like you are going
> to implement the Overlapping tiles agent.
No. These are internal function of the agent controller
(agents.c). But yes there is some docu needed.
> cause_a_unit_changed_for_agent
> cause_a_city_changed_for_agent
> can_field_be_used_for_worker
>
> Too long. I'm suggesting instead
>
> update_unit_current
> update_city_current
No. update_*_current is too general. I don't know what what current
should be. Note that an agent can activate another agent with this
function.
> is_field_free_for_worker.
Yes.
> I believe it should be ROLES, not ROLLES.
>
> +#define NUM_SPECIALISTS_ROLLES 3
Yes.
> +#define MAX_FIELDS_USED (CITY_MAP_SIZE * CITY_MAP_SIZE - 4 - 1)
>
> A bit of detail please on MAX_FIELDS, not clear on why the second part
> CITY_MAP_SIZE - 4 - 1) is needed.
Yes.
> get_city_growth_string
>
> turns = ((cost - stock - 1) / surplus) + 1 + 1;
>
> You still have not answered my question if what you meant was
>
> turns = ((cost - stock - 1) / surplus) + 1;
>
> or
>
> turns = ((cost - stock - 1) / surplus) + 2;
>
> Just curious as to why +1 + 1.
Uhh. I will think about this.
Raimar
--
email: rf13@xxxxxxxxxxxxxxxxx
A supercomputer is a computer running an endless loop in just a second
|
|
