[Freeciv-Dev] Re: init_techs integrated patch (PR#999)

[Arien Malec <arien_malec@xxxxxxxxx>]

--- Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> wrote:
> It looks to me that the termination with A_LAST is optional if the
> tech list is of size MAX_NUM_TECH_LIST. So you can have
> MAX_NUM_TECH_LIST items in a tech list. This is my reading of
> lookup_tech_list.

Good point: the documentation for lookup_tech_list should be changed, or it
should fill only to (MAX_NUM_TECH_LIST - 1).

Nitpick: the boundary conditions for the for loop are effectively tested in two
different places (in the for statement &  as an explicit break), which makes it
hard to read, IMHO. I'd prefer either a long for condition, or a while loop.

Arien

__________________________________________________
Do You Yahoo!?
Make a great connection at Yahoo! Personals.
http://personals.yahoo.com