[Freeciv-Dev] Re: init_techs integrated patch (PR#999)

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Thu, Oct 11, 2001 at 09:37:22AM -0700, Arien Malec wrote:
> Overall, looks improved: the memcpy change is a good one.
> 
> The bounds checking on array size may introduce bugs as well as save the code
> from them. If, for some reason, the code fails to A_LAST terminate in some
> circumstance, the code as it stands will fill up initial techs with some
> garbage, rather than lots of garbage or a seg fault. I guess I'd rather see
> something obviously wrong than subtly wrong.

It looks to me that the termination with A_LAST is optional if the
tech list is of size MAX_NUM_TECH_LIST. So you can have
MAX_NUM_TECH_LIST items in a tech list. This is my reading of
lookup_tech_list.

> The code below is necessary in that the game.ruleset now refers to techs, so
> you need to load game.ruleset after techs.ruleset.

I understand.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 A life? Cool! Where can I download one?