[Freeciv-Dev] Re: Comments in .diff

[Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx>]

 --- Gaute B Strokkenes <gs234@xxxxxxxxx> wrote: 
> On Mon, 1 Oct 2001, greg@xxxxxxxxxxxx wrote:
> > Gregory Berkolaiko (gberkolaiko@xxxxxxxxxxx) wrote:
> > 
> >> Is it possible to add commnets into a .diff file such that the
> >> patch command will skip them?  That would be handy.
> > 
> > Everything before the diff itself will be ignored by patch.  You can
> > write any comments you like, as long as they don't look like the
> > output of diff.
> 
> I think the point was that Gregory wanted to be able to insert
> comments inside the diff file itself, rather then up front, the idea
> being that you want to keep comments near to the stuff that is being
> modified.

that's right.

> Unfortunately, I don't think this is possible.  There is a sort of
> tradition for putting comments like "the previous way is wrong" and so
> on inside the code, which I think is a bad idea because these comments
> are seldom helpful without the appropriate context (ie. the old code).

Right again.  ai directory is full of such stuff.  sometimes there is
even the old code there which is still not helpful.  I think the comments
should be constructive, saying what is the code doing and not what it was
doing in 1998.

G.

____________________________________________________________
Do You Yahoo!?
Get your free @yahoo.co.uk address at http://mail.yahoo.co.uk
or your free @yahoo.ie address at http://mail.yahoo.ie