[Freeciv-Dev] map_same_continent().

[Gaute B Strokkenes <gs234@xxxxxxxxx>]

The function map_same_continent() is used only 7 places in the code.
Its sole task is to call map_get_continent() twice and compare the
results.

On the other hand, there are lots of places that do exactly the same
thing manually, either directly or by caching one of the results in a
variable.

As such, I do not believe that map_same_continent() serves any
appreciable purpose other than save a few characters' worth of screen
real estate in just a couple of functions.  Therefore, I propose to
remove it entirely, so that future generations of Freeciv source
readers will have one less function to digest.

-- 
Big Gaute                               http://www.srcf.ucam.org/~gs234/
A wide-eyed, innocent UNICORN, poised delicately in a MEADOW filled with
 LILACS, LOLLIPOPS & small CHILDREN at the HUSH of twilight??