[Freeciv-Dev] Re: [Patch] Remove goto_zoc_ok and dir_ok

[Thue <thue@xxxxxxx>]

On Tuesday 18 September 2001 20:04, Raimar Falke wrote:
> On Tue, Sep 18, 2001 at 07:32:39PM +0200, Thue wrote:
> > On Tuesday 18 September 2001 19:15, Raimar Falke wrote:
> > > I claim that the attached patch will not change anything on the
> > > behavior of the code. It turns out that goto_zoc_ok has never
> > > worked. Studing goto_zoc_ok reveals that it returns 1 if the
> > > can_step_taken_wrt_to_zoc is true and 0 otherwise.
> > >
> > > Thue: you made these changes. Maybe you know something I missed
> > > or can fix it.
> > >
> > >   Raimar
> >
> > Evil bug - the last return in goto_zoc_ok should be a "return 1;".
>
> So the question is: how is it possible that this wasn't found yet? To
> show the impact of the "return 1" and for futher fixing a testcase is
> really needed.
>
>       Raimar

It is a little-encountered special case. I did change the code, but 
only a small completely cosmetic change, so I guess I didn't see the 
need to test. (I don't know how I managed to change the 1 to a 0!)

-Thue