[Freeciv-Dev] Re: sorting units etc (was: Re: Re: [Patch] Sorting techs in the intelligence report)

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Sat, Sep 15, 2001 at 01:11:55AM +0200, Christian Knoke wrote:
> Am Freitag, 14. September 2001 23:13 schrieb Raimar Falke:
> > On Fri, Sep 14, 2001 at 10:10:47PM +0200, Niels Weber wrote:
> > > Hi Raimar!
> > >
> > > Raimar Falke wrote:
> > > >On Fri, Sep 14, 2001 at 12:34:18AM +0200, Christian Knoke wrote:
> > > >>Am Donnerstag, 13. September 2001 18:38 schrieb Raimar Falke:
> > > >>>Like in the attached patch? Non-military units will appear over
> > > >>> the other units.
> > > >>
> > > >>Yes, exactly :-)
> > >
> > > [...]
> > >
> > > >>And, when you're on it ;) you might consider putting the coinage
> > > >> item separate, e.g. at the end of the improvements section.
> > > >
> > > >It is at the top like the special units.
> > >
> > > IMHO coinage would be best at the bottom of the list. Sorry for the
> > > extra work ;).
> >
> > No problem if two people want it at the bottom.
> 
> Well, I'm very happy with each.
> 
> >
> > Other comments?
> 
> It's perfect. :-))

Hah. Don't leave me with a sourcecode file alone ;) The patch is now
even better[TM] and bigger. It includes a generic method which does
accept an array of compound ids (cids) and returns a sorted array of
char *. This can be used everywhere and is as a result moved to
client/climisc. I have also changed to change-all dialog.

Compound ids are the second part of the patch. From city.c:

 A compound id (cid) holds all a city can build: improvements (with
 wonders) and units. This is achieved by seperation the value set: a
 cid < B_LAST denotes a improvement (including wonders). A cid >=
 B_LAST denotes a unit with the unit_type_id of cid-B_LAST.

Such variables has been used earlier but in a rather chaotic way.

If there are no objections I will change the other clients and apply
the patch.

I still don't know a better name for the "struct item". Maybe somebody
comes up with a better one.

> Mike: could you adapt the sort order in the city dialog to
> this, i.e.: coinage, buildings, non-military-units, military units,
> wonders (sorting after translation)?

Use name_and_sort_items.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  "With a PC, I always felt limited by the software available.
   On Unix, I am limited by my knowledge."
    -- Peter J. Schoenster <pschon@xxxxxxxxxxxxxxxxx>