[Freeciv-Dev] Re: the directional system

["Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx>]

You mean this email "suggesting" use of iterate macros to cleanup
the code that wasn't in fact touched by me :-).

No attack was implied or intended ... but the response is pretty 
sharp. Peace?

Cheers,
RossW

At 11:34 AM 01/09/10 +0200, Thue wrote:
>On Monday 10 September 2001 07:13, Ross W. Wetmore wrote:
>> >Exactly. And even at this one place it provides no advantage. Thue?
>>
>> I'm surprised he managed to get it in. But I suspect when he asked
>> me to put more of this stuff into the mapgen updates before 12.0 he
>> knew this would effectively block any map improvements until more
>> of his fixes were adopted :-).
>
>I did not ask you to put more stuff into the mapgen code. I pointed out 
>some errors and then asked you to post followups to freeciv-dev, as I 
>wouldn't have time to look at the patches.
>
>Very little was changed just before 1.12.0, as we were in a virtuel 
>feature freeze. If in introduced DIR_D[XY]2 it was probably just as a 
>cleanup of something that was already there. So no, I did not look very 
>deeply at your patches because they were a bigger change that was not 
>appropriate at the time.
>
>Please don't try to argue by making accusations at the other part. It 
>is extremely bad form. And I certaintly don't have time to participate 
>if I am going to be attacked like that.
>
>-Thue

> From: Thue <thue@xxxxxxx>
> To: "Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx>,
>  Mike Kaufman <mkaufman@xxxxxxxxxxxxxx>
> Subject: Re: Latest mapgen.c - reworked mapgenerators 2-4
> Date: Mon, 11 Jun 2001 13:36:33 +0200
> X-Mailer: KMail [version 1.2]
> 
> On Monday 11 June 2001 02:52, Ross W. Wetmore wrote:
> > I added a bit of commentary to the code to help decipher some of the
> > algorithms and/or rationale, but it is still pretty dense - I have
tried to
> > work within the current coding style and basic flow. But at some point I
> > will breakdown and overhaul it in a major way if I keep going.
> 
> Some of it is not very pretty; yes.
> 
> > Anyway, any feedback and/or suggestions for areas that are deemed weak, or
> > desired characteristics and ranges/controls to manipulate them are always
> > welcome.
> 
> You should send it to freeciv-dev to get feedback.
> Just from a very short look:
> 
> cartesian_adjacent_iterate(x, y, x1, y1) {
>    if (myrand(10)>5) make_forest(x1, y1, height, diff-5);
> } cartesian_adjacent_iterate_end;
> 
> is superiour to stuff like
> 
> if (myrand(10)<4) make_forest(x-1,y, height, diff-600);
> if (myrand(10)<4) make_forest(x+1,y, height, diff-600);
> if (myrand(10)<4) make_forest(x,y-1, height, diff-400);
> if (myrand(10)<4) make_forest(x,y+1, height, diff-400);
> 
> as cartesian_adjacent_iterate will only return those tiles that do not fall 
> off the map, and furthermore it will have adjusted the values (ie x=-1 => 
> x=map.xsize-1). Finally it is nicer to look at and use :).
> As a rule you should make sure tile coordinats are valid and adjusted 
> _before_ you use them. The *_iterate macros make this easy.