[Freeciv-Dev] Re: Re strange msg concerning ais (PR#928)

[Paul Zastoupil <paulz@xxxxxxxxxxxx>]

On Mon, Sep 10, 2001 at 08:48:05PM +0200, Raimar Falke wrote:
> On Mon, Sep 10, 2001 at 11:23:13AM -0700, Paul Zastoupil wrote:
> > On Mon, Sep 10, 2001 at 12:03:50PM +0200, Raimar Falke wrote:
> > > On Sun, Sep 09, 2001 at 07:52:06PM -0400, Jason Dorje Short wrote:
> > > > Raimar Falke wrote:
> > > > > 
> > > > > On Sun, Sep 09, 2001 at 02:16:05PM -0700, Christian Knoke wrote:
> > > > > > 1.12.1
> > > > > >
> > > > > > Got the same, this is the client output:
> > > > > >
> > > > > > Server capability string: +1.11.6 conn_info pop_cost turn 
> > > > > > attributes new_bonus_tech fund_added
> > > > > > Welcome to the Freeciv version 1.12.1-devel Server running at 
> > > > > > civserver.freeciv.org port 5570.
> > > > > > Game: Sapporo may soon grow to size 2.
> > > > > > Karamazov: '/ai Stimpos'
> > > > > > Game: Stimpos is now AI-controlled.
> > > > > > Game: Player 'Stimpos' now has skill level 'easy'.
> > > > > > Karamazov: '/hard'
> > > > > 
> > > > > > Game: AI players now have skill level 'Bragu'.
> > > > > 
> > > > > I can't find this message in the source. Either it is constructed at
> > > > > runtime or something weird is going on.
> > > > 
> > > > Game: AI players now have skill level 'jshort'.
> > 
> > I think this is what is at fault.  Its one of Reinier's auto applied
> > patched to cvs on civserver.freeciv.org.  
> > 
> > +    notify_player(0, _("Game: Player '%s' now has skill level '%s'."),
> > +           pplayer->name, name_of_skill_level(level));
> 
> gcc also warns about it.

Actually that was the wrong line, it was: 

+    notify_player(0, _("Game: AI players now have skill level '%s'."),
+               pplayer->name, name_of_skill_level(level));

I changed it to:

+    notify_player(0, _("Game: AI players now have skill level '%s'."),
+               name_of_skill_level(level));

Should be able to close the bug.

-- 
Paul Zastoupil