[Freeciv-Dev] Re: [Patch] New city dialog (8a)

[Mike Kaufman <mkaufman@xxxxxxxxxxxxxx>]

On Thu, Sep 06, 2001 at 02:53:46PM +0200, Christian Knoke wrote:
> Am Mittwoch,  5. September 2001 22:23 schrieb Mike Kaufman:
> > Ok, I've put a ver 8a of the new_city_dialog on the ftp site in
> > incoming/ In fact, you all get a bonus: two versions!
> 
> I think it is now in a state, where it can respectfully replace
> the old city dialog. Everything goes smooth, and it's not too big
> anymore!
> 
> There are some real minor bugs and cosmetic things yet, I wish
> to comment on. Most of this has been said, I just mention it
> so they will not get lost:
> 
> >
> > new_city_dialog8a-normal.diff.gz:
> >
> > a new version of city_dialog.
> > o more internal work. notebook pages moved to functions, more cleanup
> > o the happiness dialog plays nice when switching cities
> 
> Well, the display of the text within still isn't nice. I'll put up
> a picture on http://www.enter.de/~c.knoke/bugs/happiness.png
> 
> so you can see it.

yes, I _attempted_ to correct this, spent an hour, gave up. Someone smarter 
than me is going to have to look at it. Actually, now that I think about it 
there is another thing that I can try, however, I assume at the present this is 
a GTK bug. Get back to you.

> 
> > o worklist help by Daniel Sjölie
> > o column_spacing fix by Daniel Sjölie
> > o more shortcuts: Enter closes dialog; [,],c,u,w,h,t,m switches pages
> 
> Could you please make them translatable, and mark them with "_" ?

Hmm, I'm not sure how... Anyone, anyone? These use the keyboard_handler, which 
uses GDK_key as the method, I'm not sure how, or if you'd want to do this. 
> 
> Now, that you have these, I'd really like to have (<begging>) "Ins" and 
> "Del" keys for the worklist items.

This is for Daniel. I haven't looked a great deal at the worklist code. 

> I couldn't find out what the [,] does?

This _should_ just decrement and increment the page number. 
Overview -> Units -> Worklists etc.

> When you insert an item into the worklist (currently building), some columns
> may become invisible. But there is enough space, so resizing should help.
> If you can't reproduce it, please use german locale.

I'm not sure I understand. (ugh, locales... I'll see, again a worklist issue).

> 
> The title of the dialog should be the city name alone. This affects the
> presentation of the dialog in the task bar.

Just as a thought, this is the behavior of the old dialog.
I looked briefly at it, and it seemed a lot of trouble for the result...

> 
> Shortcuts for "Buy" and "Change" in the overview.
> 
> When you switch to "next city", the map is not centered. Are there
> performance reasons? (Not for me, 200 MHz)

Never came up. I suppose this could happen. We'll see.

> 
> The sensitive area bug.

yup, I see the same thing you do. This I don't think I can fix. Somebody else 
with the pixcomm knowledge needs to look at it. I'm presuming that the problem 
is somewhere in tilespec.c. the tiles are not getting drawn where they're 
supposed to.

> 
> There is a tooltip now (for the granary numbers), but no enable
> tooltips switch.

yes, yes. Is it that big a deal? Again, I'll see what I can do.

> 
> >
> > city_dialog8a-trade.diff.gz
> >
> > o everything above.
> > o traderoutes moved to new page.
> > o supported and present units moved to an over-and-under format on
> > the overview page
> 
> I really like this one, and would prefer it.

me too.

> 
> >
> > After doing the traderoute move, I find that I really like it, even
> > if the traderoutes dialog is huge. I haven't done a whole lot of
> 
> You could make the "Establish trade routes" Frame smaller and centered.
> Could this have a white background?

why?

> 
> > testing on this. Somebody check adding traderoutes and spying and see
> > if there's any problems.
> 
> I did. No problems, except: If a city has four traderoutes, it is
> not possible to establish another traderoute. AFAIK, the worst/oldest
> should be replaced by a new one. But this may not be an issue of
> your dialog, it only becomes visible now!

Yes, I noticed this too. Question to developers, etc. Why is this so?
That seems to limit one's options in terms of an economic victory...

-mike

PS: my time is becoming seriously limited. Some of the nitpicky points might 
have to get ironed out after inclusion. (Or somebody else can help in the 
effort, anyone?)