[Freeciv-Dev] Re: 3 patches for use on public gameservers

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Mon, Aug 20, 2001 at 01:02:33AM +0200, Reinier Post wrote:
> These are all patches to command handling in to server/stdinhand.c.
> 
> The first patch sets the minimum timeout to 40 and is already in effect
> on civserver.freeciv.org.  A timeout of 0 is still allowed as a special case.
> 
> The second makes it impossible for clients to /end a game.
> (It does nothing to prevent them from typing /set endyear -3950).
> 
> The third notifies all players of the execution of a command.
> This way you can point fingers in case of accidents or abuse.

Come'on people I can't be the only one who comment on patches?! The
first one would need adjustment to allow autogame mode.

> @@ -1102,8 +1102,12 @@
>     /* TRANS: translate text between <> only */
>     N_("remove <player-name>"),
>     N_("Fully remove player from game."),
> +   /*
>     N_("This *completely* removes a player from the game, including "
>        "all cities and units etc.  Use with care!")
> +    */
> +   /* note: cannot be used once game has started due to problems with
> +      player renumbering - make it ALLOW_HACK once this is repaired - rp */
>    },

What is the reason for this?


> @@ -1409,8 +1413,10 @@
>    if (send_server_info_to_metaserver(1,0)) {
>      notify_player(0, _("Open metaserver connection to [%s]."),
>                 meta_addr_port());
> +    /*
>      cmd_reply(CMD_METACONN, caller, C_OK,
>             _("Metaserver connection opened."));
> +    */
>    }
>  }

Why no just deleting it?

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "A common mistake that people make, when trying to design 
  something completely foolproof is to underestimate the 
  ingenuity of complete fools."
    -- Douglas Adams in Mostly Harmless