[Freeciv-Dev] Re: 3 patches for use on public gameservers

[Reinier Post <rp@xxxxxxxxxx>]

On Tue, Aug 28, 2001 at 06:49:06PM +0200, Raimar Falke wrote:

> > @@ -1102,8 +1102,12 @@
> >     /* TRANS: translate text between <> only */
> >     N_("remove <player-name>"),
> >     N_("Fully remove player from game."),
> > +   /*
> >     N_("This *completely* removes a player from the game, including "
> >        "all cities and units etc.  Use with care!")
> > +    */
> > +   /* note: cannot be used once game has started due to problems with
> > +      player renumbering - make it ALLOW_HACK once this is repaired - rp */
> >    },
> 
> What is the reason for this?

This is not really related, but the /remove command was made pregame-only
a while ago, so the comment is wrong.  I thought a comment to list the
reason was in order.
> 
> > @@ -1409,8 +1413,10 @@
> >    if (send_server_info_to_metaserver(1,0)) {
> >      notify_player(0, _("Open metaserver connection to [%s]."),
> >               meta_addr_port());
> > +    /*
> >      cmd_reply(CMD_METACONN, caller, C_OK,
> >           _("Metaserver connection opened."));
> > +    */
> >    }
> >  }
> 
> Why no just deleting it?

I'm not sure if everyone wants these messages to go away.

>       Raimar

-- 
Reinier