[Freeciv-Dev] Re: [PATCH] slight optimisation at client/packhand.c

[Kevin Brown <kevin@xxxxxxxxxxxxxx>]

Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> wrote:
> On Wed, Aug 15, 2001 at 07:18:35PM -0700, Trent Piepho wrote:
> > On Thu, 16 Aug 2001, Gaute B Strokkenes wrote:
> > > This needs more spaces.  Also, the && should be at the beginning of
> > > the line, not the end.
> > 
> > Other people (like me) like && at the end better, and it's more common that
> > way in the code.
> 
> I also like the && at the end and some other things. However you have
> to follow the rules. This is easy if you use emacs and something like:

[...]

Oooh...I like!  Very cool.  Just one thing:

>    "indent -kr -i2 2>&1 | grep -v Unexpected" 1)

Shouldn't you be directing stderr to /dev/null?  Or perhaps not at
all?  Will emacs Just Do The Right Thing if it sees output on stderr?

In any case, what do you do if your source contains the word
"Unexpected"?  :-) :-)


Of course, Emacs uses the K&R 2-character indentation mode for C/C++
by default anyway, doesn't it?  So indent-region should just work,
right?



-- 
Kevin Brown                                           kevin@xxxxxxxxxxxxxx

    It's really hard to define what "unexpected behavior" means when you're
                       talking about Windows.