[Freeciv-Dev] Re: [PATCH] slight optimisation at client/packhand.c

["Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx>]

At 07:18 PM 01/08/15 -0700, Trent Piepho wrote:
>On Thu, 16 Aug 2001, Gaute B Strokkenes wrote:
>> This needs more spaces.  Also, the && should be at the beginning of
>> the line, not the end.
>
>Other people (like me) like && at the end better, and it's more common that
>way in the code.

I like Gautes' way; this is indent -kr2 -bbo, which puts it on the wrong
side of the rules though.

As an argument for this, it is usually the case that code changes to add
insert and modify are simpler as each line tends to have the operation and
value it wants to use, rather than the operation having a "continuation"
at the end of a previous line, and include the "continuation" at the end
of this one for the next operation argument. Operations are evaluated from
left to right, so preceding elements are "complete" unless one is doing
a followup (binary) operation.

Cheers,
RossW