[Freeciv-Dev] Re: Profiling Civserver again

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Thu, Aug 02, 2001 at 07:56:48PM -0400, Ross W. Wetmore wrote:
> At 09:54 AM 01/08/02 +0200, Raimar Falke wrote:
> >On Wed, Aug 01, 2001 at 09:59:52PM -0500, Mike Kaufman wrote:
> >> On Wed, Aug 01, 2001 at 09:27:04PM -0400, Ross W. Wetmore wrote:
> >> > Defensive programming like defensive driving is worthwhile if it doesn't 
> >> > cost that much more to implement or follow the right habits.
> >> 
> >> yes, but this whole discussion started as a result of "hey this
> >> function got called umpteen million times!" It might be interesting
> >> to see what the differences are between modulus and while loops and
> >> such in the macro, but if a little care can avoid the problem, I say
> >> we might as well try.
> >> 
> >> Besides, (not following the list as carefully as he should) has
> >> anybody checked to see how often (and where) the code goes outside
> >> of [-map.xsize,2*map.xsize]?
> >> If it doesn't, why build in a lot of defensive cruft into the code?
> >
> >I agree. We should make it fatal and see what breaks. AFAIK the only
> >time where an interim value is outside is, that you go from a valid
> >position one step in a direction.
> 
> I'd like to amend this slightly :-). 
> 
> We should make this fatal during development or in development builds, and
> turn off the behaviour or revert to defensive code when the release is in
> final beta or goes out.

Ok. So lets wait for the new development version.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "The Internet is really just a series of bottlenecks 
  joined by high speed networks."
    -- Sam Wilson