[Freeciv-Dev] Re: Profiling Civserver again

[Reinier Post <rp@xxxxxxxxxx>]

On Wed, Aug 01, 2001 at 06:31:27PM -0500, Mike Kaufman wrote:
> Perhaps someone could answer this for me: why do we _have_ to assume possible 
> X values outside [-map.xsize,2*map.xsize] ? When would this (legitimately) 
> happen?

The screen can be much wider than the map.  The last time I tried this out
was 2 years ago, and the screen updating was broken then (see

  http://www.freeciv.org/~hop/examples/wrap1.jpg
  http://www.freeciv.org/~hop/examples/wrap2.jpg

).  With the tinydent tiles, it's easy to wrap around several times.

> If a function is (naughtily) setting X too big or small, let's correct the 
> function. Grepping through the code, I don't see a massive number of places 
> where map_adjust_x() is called. Ought not be that hard to track down. Someone 
> please correct my naivete

Would it be helpful to turn absolute screen coordinates, relative
coordinates and map coordinates into different C types?  That way
the type checker could help out.

> -mike

-- 
Reinier