[Freeciv-Dev] Re: PATCH: Advanced City Name Generation (version 2)

[Erik Sigra <sigra@xxxxxxx>]

tisdagen den 30 januari 2001 21:28 skrev Erik Sigra:
> I discovered a serious bug in the patch. When you have requested all the
> names in a random namer, you should get the suggestion "? no more names?",
> but instead, the servers enters a long loop and eventually returns the
> suggestion "" to the client.
>
> I spent a few hours searching for the problem and finally found it. The
> problem is that the random functions work different in Freeciv than in
> Xconq, which makes porting stuff problematic; Xconq's xrandom(0) returns 0,
> while Freeciv's myrand(0) returns a random number up to Integer'Last. This
> random number is then the number of iterations the server will spend in the
> long loop.

The new patch is at 
<ftp://ftp.freeciv.org/pub/freeciv/incoming/citynames-3.diff.bz2>. The random 
bug is fixed, strings are marked for translation and some stuff is cleaned.