[Freeciv-Dev] 1/3 or 2/3 move left: Confirm attack

[Kero van Gelder <kero@xxxxxxxxxxxxxxxxxxxxxx>]

Hi!

Patch asks (human) player for confirmation when he/she attacks with
units that have no full movement point left.

I got annoyed a few times when I set my unit on GoTo, such that it
would attack next turn, when it had 1/3 movement left and attacked
immediately. Bye bye unit.

Since it must work for normal movement and for GoTos, implementation
had to be done in the server. Hence a new packettype saw the light and
hops the network. To rerun a set of checks when the user confirmed
(hey, target may have walked away :-) I added a boolean ``confirmed''
to the parameter list of handle_unit_move_request(). [Which made me
wonder why the parameter igzoc is there, isn't it derivable from the
unit(id)?]

Patch applies to 1.11.5-devel (from CVS). Release of 1.11.4 is nicely
on schedule, such that I can submit this patch and leave on holiday!

Bye,
Kero.

+--- Kero --------------------------------- kero@xxxxxx ---+
|  Don't split your mentality without thinking twice       |
|                          Proud like a God -- Guano Apes  |
+--- M38c ------------------ http://huizen.dds.nl/~kero ---+

confirm_attack.diff.gz
Description: application/gunzip