[Freeciv-Dev] fix bug in smooth move draw and lots more

[Jeff Mallatt <jjm@xxxxxxxxxxxx>]

I noticed a bug in both the GTK+ and Xaw clients' move_unit_map_canvas()
routines: the intermediate images as drawn contained a bunch of garbage
around the edges (if solid color off and flags transparent).  (Actually, in
GTK+ the "garbage" was a solid white background.)

Well, to fix the bug, it helps to see it -- and to see this bug when
running the clients, I had to throttle the smooth move drawing.  This being
a request from awhile ago, I decided to implement it for real (rather than
just for test purposes).  To put the throttling under user control, I
needed to implement client options that were integers (rather than just
booleans).

The attached patch does all this.

smooth-move-fix-plus-1.diff.gz
Description: Binary data

jjm