Complete.Org: Mailing Lists: Archives: freeciv-dev: May 2000:
[Freeciv-Dev] Re: fix recent misuse of LOG_FATAL
Home

[Freeciv-Dev] Re: fix recent misuse of LOG_FATAL

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: fix recent misuse of LOG_FATAL
From: Thue Janus Kristensen <thue@xxxxxxx>
Date: Thu, 11 May 2000 18:39:20 +0200

On Thu, 11 May 2000, Jeff Mallatt wrote:
> 
> LOG_FATAL should be, er, well, *fatal* -- ya know?
> 
> Attached is a patch which changes some recent LOG_FATALs into LOG_NORMALs,
> and makes others actually fatal.
> 
> I just looked at recent changes; didn't do an exhaustive search.
> 
> Has anyone else ever thought that there maybe should be a LOG_WARNING
> between LOG_FATAL and LOG_NORMAL?
> 

The wrap error is quite fatal; things will look very funny in the
affected players client if it happens. Doesn't this qualify?
The third one you changed is an error that will lead to the wrap error

-Thue



[Prev in Thread] Current Thread [Next in Thread]