Complete.Org: Mailing Lists: Archives: freeciv-dev: May 2000:
[Freeciv-Dev] Re: fix recent misuse of LOG_FATAL
Home

[Freeciv-Dev] Re: fix recent misuse of LOG_FATAL

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: fix recent misuse of LOG_FATAL
From: Jeff Mallatt <jjm@xxxxxxxxxxxx>
Date: Thu, 11 May 2000 13:52:19 -0400

At 2000/05/11 12:39 , Thue Janus Kristensen wrote:
>On Thu, 11 May 2000, Jeff Mallatt wrote:
>> 
>> LOG_FATAL should be, er, well, *fatal* -- ya know?
>> 
>> Attached is a patch which changes some recent LOG_FATALs into LOG_NORMALs,
>> and makes others actually fatal.
>>[snip]
>
>The wrap error is quite fatal; things will look very funny in the
>affected players client if it happens. Doesn't this qualify?
>The third one you changed is an error that will lead to the wrap error

Sure.  I wasn't familiar with the ramifications of the code, so anything
that wasn't *obviously* fatal I didn't make fatal.

Here's a patch that changes these two back to LOG_FATAL, and makes them so.

Attachment: log-fatal-fixes-1.diff
Description: Text document

jjm

[Prev in Thread] Current Thread [Next in Thread]