[Freeciv-Dev] old/bad code in autoattack.c (PR#351)

[thue@xxxxxxx]

Full_Name: Thue Janus Kristensen
Version: CVS
Distribution: Built from source
Client: Both (or N/A)
OS: linux
Submission from: (NULL) (194.239.210.2)
Submitted by: thue


In server/autoattack.c a simple comparison of the unit types' defence values is
used. This is far too crude. It does not take in to accound terrain and special
bonuses like pikemen vs horses
Also, why does it use
        if (debug) freelog(LOG_DEBUG, ..);
instead of just 
        freelog(LOG_DEBUG, ...);
?

(I don't have time to fix this now myself, just using this as a memo and hoping
maybe someone else will fix it)