[Freeciv-Dev] Re: old/bad code in autoattack.c (PR#351)

[Thue Janus Kristensen <thue@xxxxxxx>]

On Sat, 29 Apr 2000, Nicolas BRUNEL wrote:
> > In server/autoattack.c a simple comparison of the unit types' defence 
> > values is
> > used. This is far too crude. It does not take in to accound terrain and 
> > special
> > bonuses like pikemen vs horses
> 
> It's really too crude. I'm afraid the same formula is used when a town is
> defending itself. I saw many warriors wasted in an attemp to destroy a
> phalanx on a mountain. It would be better to build a more powerfull
> attacking unit. One day someone will have to rewrite the code responsible
> for that.
>[...]

But isn't the code in autoattack.c used only for players putting their
units on autoattack?
Anyway, there must be a function to calculate the excact value in the AI
somewhere. I was just too lazy to try to find it.

-Thue