[Freeciv-Dev] Re: fix Gtk+ City Report; was Re: two bugs (PR#259)

[David Pfitzner <dwp@xxxxxxxxxxxxxx>]

David Pfitzner wrote:

> This suggests that a solution would be to avoid doing
> the remove/putback thing.  This patch tries to do this,
> by instead updating the row in-place.
> 
> Seems to work ok...  I can no longer reproduce the crashes
> and/or display/memory garbage problems, and haven't noticed
> any other problems.

A possible complaint with my fix is that changes via
city_report_dialog_update_city() do not update the sorting
of the list.  If desired, adding a call to
        gtk_clist_sort(GTK_CLIST(city_list));
(after gtk_clist_thaw?) should fix.

(Incidently, it looks like this bug is the same as open
bug PR#160.)

-- David