[Freeciv-Dev] Re: Another crash

[Corin Anderson <corin@xxxxxxxxxx>]

Okay, here's a new patch that should fix the worklist bugs you've found.
Note that this patch is relative to the current CVS image and thus
incorporates my previous fixes.  This patch:

* Fixes the two worklist-related crashes you've seen (both stem from an
  off-by-one error letting a bad value sneak into the worklist);
* Fixes many 'bad string length in packet' errors;
* Purges improvement targets that can never be built (because they already
  exist in the city, because a wonder exists that obsoletes them, or
  because the city isn't on or adjacent to the right terrain);
* Purges unit targets that can never be built (because the city isn't on
  the right terrain);
* Limits the future targets listed for a city worklist to those that a
  specific city can build -- an inland city won't ever get to put a harbor
  on its worklist.  Also, inserted global worklists are screened by the
  same test as they are fed into the worklist for the city.

This patch affects server code (to fix cityturn handling of worklists),
common code (some helper functions in city.[ch]), and client code (common
code, Xaw, Gtk, and mui clients are updated).

Please let me know if you have more trouble with the worklists
misbehaving.  

Corey

worklist-20000204.patch.gz
Description: Binary data