[Freeciv-Dev] Re: Removed players

[paulz@xxxxxxxxxxxxxx]

On Thu, Jan 13, 2000 at 02:29:56AM +0100, Peter Schaefer wrote:
> 
> 
> 
> >Is there a reason we have to game_renumber_players when we remove
> >someone?
> >Is there anyway to leave the player in the game.players?
> >Its causing some confusion in the civscore.log and .sav files.
> >
> >Just wondering.
> >--
> >Paul Zastoupil
> >
> 
> Seconded. Reason:
> I thought about the following data, for each (ai-) player an array of
> integers that sums up
> how annoyed the player is about another player. This would be used to decide
> whether to go to war,
> and maybe for republic/democracy senate vetoing going to war.
> If players are renumbered, all such data structures get more complicated to
> access or maintain.

Ok another good one.  This could also apply to things other than
diplomacy, any stucture refering to player numbers.

> 
> On the other hand .. You could argue you need a function similar to
> renumbering anyway whenever
> an empire is split by civil war. Civil war is also a reason why you might
> want to drop one player
> and renumber the rest.

Yes, this is a good point.  I guess I didn't mean that we should get
rid of renumbering, just that the player should stay in game.players.

> 
> However, some issues for renumbering:
> - if a player is removed before the game starts, the player should not
> occupy the slot of another player.

Ok good "special case" 

> - if removed players stay in the game, they have to be saved and loaded
> properly.

Yes, this is where the problem is cropping up, savegames should contain
removed players.

-- 
Paul Zastoupil