[Freeciv-Dev] Re: patch for "ran out of continents in client" bug

[David Pfitzner <dwp@xxxxxxxxxxxxxx>]

Peter Schaefer wrote:

> >I think the arctic and antarctic need not be special cases
> >in the client.  Indeed in general the client may not know if
> >a given square is connected to the arctic/antarctic, as in
> >the example you give.  (Or there could be multiple disconnected
> >arctic/antarctic continents, although not sure if the _server_
> >handles this correctly.  Ie in a scenario.)  Actually, does the
> >client even know the correct value of generator?  I suspect not.
> >
> The code that does this does not break the other continents when it is off
> or not.

Right, and since it doesn't do anything useful, that code should 
be left out in the name of code simplicity :-)

> >Yep, thats what I hoped.  Any reason for an explicitly signed short?
> >(I would have thought just short, or unsigned short if being explicit.)
> 
> I thought you would ask. The way it is before, the function get_continent
> does use a char, which is different from the unsigned char of the continent
> value.
> I wanted to point out by making it signed short that it is not by accident
> signed :-)

Yes, it makes it clear its deliberate; that raises the question
when reading the code of _why_ its deliberate, which I'm still 
not sure of... :-/

-- David