[Freeciv-Dev] Re: Game reports Hoover dam is unavailable. (PR#135)

[sebauer@xxxxxxxxxxx (Sebastian Bauer)]

Hello,

> Jeff Mallatt quickly identified the problem, my auto-settler engineer
> had transformed the mountain.

I thought so too.

> I, of course (lazy me), didn't go digging in the source for this one.

> I ASSuMEd that since it said it was "no longer available" it was a
> problem in the server...

> Perhaps we need more than one return value in could_build_improvement()
> in common/city.c to clear this up?

Eighter this or we change the text. If a wonder has been build I
think after the wondername there will be a capital B in the brackets
so this would be enough.
E.g. Improvement/Wonder %s cannot be build in the city %s.

> I know its an odd situation but...
> This is a bigger patch than I have time for today (what?! me make a
> patch *gasp*) but I could do it if it was thought to be helpful.

If not so many parts use this function this would be useful.
We also can add are futher argument (char *) where the function
stores the correct reason in plsain ascii. Then we needn't to
change the return value (because the function is called "could..."
there are are only two states. Eighter it could be build or
not).

bye,
Sebastian Bauer