[Freeciv-Dev] MFC&GTK client

[Andy Black <ablack@xxxxxxxxxxxxxx>]

Hi

First, In the subroutine put_nuke_mushroom_pixmaps in gui-gtk/mapview.c
in part:
  gdk_flush ();
  sleep(1);

  update_map_canvas(map_canvas_adjust_x(abs_x0-1),

Is the call to sleep() intended to be a call to myusleep?
If it is, that typo should be fixed.

On the mac client, I think the difference is the myusleep gives other
programs procesor time, and sleep doesn't.

Second: Metroworks Codewarior 10 includes a #define in unistd.h for getuid
and geteuid .  Those functions are defined to be an int of 200.  Therefore,
the mac portion in the dont_run_as_root in shared.c could and should be
removed.  ie: change
#if (defined(GENERATING68K) || defined(GENERATINGPPC) || defined(__EMX__))
to
#ifdef __EMX__
My logic for making that change is possible/probabal future support for
those functions.  mac os 9 will include the ability to have a login screen.

for reference, functions that codewarior #defined are getpid(), getppid(),
getuid(), geteuid(), getgid(), getegid(), getpgrp()

Third: should put_nuke_mushroom_pixmaps center the screen on the location
of the explosion when it happens?  that would make sense because it would
draw your attention to the explosion (and enable you to think of an
appropriate response/actions for that area)  OTOH, moving the map would
make you lose your focus with whatever you were doing.  should this
decision be a client option?

Andy Black