Re: [Freeciv-Dev] caravan behavior

[David Pfitzner <dwp@xxxxxxxxxxxxxx>]

Fabrice Noilhan <Fabrice.Noilhan@xxxxxx>

> I was fed up cheating with my caravans so I looked into the code...
> The problem is that you can gain a move using a move when you're near
> a city and want to help to build wonder even if you can't move to this
> city (i.e. 0 moves left). This seems nonsense to me.

Yeah, I agree this should be considered a bug.

> I think the following patch should solve this problem, but I have not
> tested it and have never really deep into freeciv source code. At least,
> the problem is located at this place in the code.

One possible problem is that if the caravan has _some_ movement
left, but not the full amount needed for the move, then normally
it would have a random chance to complete to move.  But that 
becomes much more complicated when combined with trade/wonder
dialogs, and I'm not sure what would be the best approach...

Regards,
-- David