Re: [Freeciv-Dev] helicopters no longer lose HP

[Daniel Burrows <Daniel_Burrows@xxxxxxxxx>]

On Thu, Feb 18, 1999 at 10:22:02AM +1100, David Pfitzner was heard to say:
> Daniel Burrows wrote:
> > 
> >   Ok, this was my fault.  I think the attached patch should fix things but
> > I don't have a game handy with helicopters.  The semantics of
> > hitpoint-regeneration with this are:
> > 
> > * The United Nations and helicopter effect are applied regardless of unit
> >   type.
> > * If a unit has moved, hp_gain_coord() returns 0 for it; otherwise it 
> > returns
> >   the normal value.
> > * hp_gain_cord() gives a bonus to units on fortresses or cities, regenerates
> >  units in cities with a barracks/port/airport entirely, and gives a bonus
> >  to fortified funits.
> 
> I would have expected a unit which ends its turn in a Barracks (etc)
> to recover hitpoints regardless of movement, but now it only works
> if the unit hasn't moved, right?  Is that intentional?  If so then
> the help on Barracks etc should make this clear.  

  Yes.  I thought that was how things worked in CivII..units should have
to stay put for a turn to be healed.

> > +  pcity=city_list_find_id(&pplayer->cities, game.global_wonders[B_UNITED]);
> > +  if(pcity && !wonder_obsolete(B_UNITED))
> 
> Better (faster) to use 
>      if (player_owns_active_wonder(pplayer, B_UNITED))

  Ok.  I didn't write that line, I just indented it. :-)

-- 
  Daniel Burrows

"When I get a little money, I buy books.  If I have any left over, I buy
 food and water."

  -- methinks that the person who said this was shopping for course textbooks
    at the Brown Bookstore.