[freeciv-ai] Re: (PR#6567) AI has too many boats.

["Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=6567 >

On Sun, 22 Feb 2004, Gregory Berkolaiko wrote:

> 1. Logic
> +    if (!pcity->ai.choice.need_boat && !pcity->is_building_unit
> +               && !unit_has_role(pcity->currently_building, L_FERRYBOAT)) {
> +      continue;
> +    }
> is flawed.  Aligment is also flawed.
> 
> 2, Convert really_needed to bool.  Keep it as local as possible
> 
> 3. Don't let other players' boats deter us from going to the city that 
> needs us.
> 
> 4. We will look for nearest friendly city even if we are currently in one.
> 
> Please fix and resubmit.

Also, can we check if the present city needs us before we cycle through 
other cities?

G.