[freeciv-ai] Re: AI Diplomacy v8 (PR#2413)

["Per I. Mathisen" <per@xxxxxxxxxxx>]

On Tue, 4 Mar 2003, Raimar Falke wrote:
> IMHO you make the same error again: hardcoding constants all over the
> code. It should be the goal to divide the algorithm from the policy.

There is no framework to do so. Putting them into existing frameworks
(server vars, rulesets) is too cumbersome and will unnecessarily bloat
these.

> Missing i18n.

Oops.

> Nice:
>
> > /* Count big cities as twice the threat */
> > city_list_iterate(aplayer->cities, pcity) {
> >   kill_desire += pcity->size > 8 ? 1 : 0;
> > } city_list_iterate_end;
>
> 2*0 == 1???

It is the second time we do this, hence the "twice" part.

  - Per