[freeciv-ai] Re: coreai: ai_new_spend_gold() (new version)

["Per I. Mathisen" <per@xxxxxxxxxxx>]

On Sat, 31 Aug 2002, Gregory Berkolaiko wrote:
> I didn't read the original code in detail: it frightened me :(

Me too. That's why I pretty much killed it all ;)

> 1. It seems that the value assigned to upgrade_limit conflicts with how it
> is used in the upgrade_units routine.

Ah, in the urgency case, we don't say how much should be left alone, but
how much we can spend... very bad.

> 2. The numbers8 and 25 look like good candidates for expansionist
> behaviour variables.Maybe you should make them at least defines, for the
> time being.

Maybe variables later, for now I think it is clearer to have the numbers
there rather than defines.

> 3. Didn't notice anything being done to triremes...

They are upgraded as part of civilian upgrades. I should perhaps give them
an addition push towards upgrading since they are dangerous...

> 4. Maybe you can introduce LOG_UPGRADING define to log all upgrade-related
> issues.I'd expect some buggy behaviour (usual thing), so we could catch
> bugs easier.

Ok.

Yours
Per

"I don't see why people are so upset about cloning sheep. American
television networks have been doing that to their audiences for years."
-- Jello Biafra