Re: Darwin patches

[John Goerzen <jgoerzen@xxxxxxxxxxxx>]

Michael Witten wrote:
> On 26 Sep 2008, at 10:43 AM, Michael Witten wrote:
> 
>> Frankly, the original code doesn't even make much sense, and
>> moreover it's not forward compatible with python 2.6, and
>> furthermore:
>>
>>   DeprecationWarning: socket.ssl() is deprecated.
>>
>> So, this commit is just a temporary fix.
> 
> I see that recently the following patch was included:

Are you saying that when MacOS X switches to Python 2.6, the entire
patch will be unnecessary?

> Also, you guys seem to be wasting a lot of cycles every read():
> 
>> if (system() == 'Darwin') and (size>0) :
> 
> Shouldn't that information be cached somewhere? Why not bind 'read' to
> a particular implementation at program startup, so that there is  
> virtually
> no overhead.

A patch would be welcome on that.  I have no MacOS box on which to test.


-- John

> 
> Sincerely,
> Michael Witten
> 
> 
> 
>