Complete.Org: Mailing Lists: Archives: freeciv-dev: November 2005:
[Freeciv-Dev] Re: (PR#14443) city walls not visible (effects problem) 		Home

[Freeciv-Dev] Re: (PR#14443) city walls not visible (effects problem)

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: chrisk@xxxxxxxxx, per@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#14443) city walls not visible (effects problem)
From: "Vasco Alexandre da Silva Costa" <vasco.costa@xxxxxxxxx>
Date: Sun, 20 Nov 2005 11:33:14 -0800
Reply-to: bugs@xxxxxxxxxxx 
<URL: http://bugs.freeciv.org/Ticket/Display.html?id=14443 >

On 11/20/05, Vasco Alexandre da Silva Costa <vasco.costa@xxxxxxxxx> wrote:
> If you look at the places which use city_got_citywalls inside advmilitary.c,
> in one you have a unit pointer, and in the other you have a unit type pointer.
> Can't we just use those?

Now I notice those are *defender* units, not the attacker unit. Blech.

Shouldn't the EFT_DEFEND_BONUS effects queries be passed the defender unit,
rather than the attacking unit, like effects.c says? They are defender
modifiers after
all, no?
[Prev in Thread] Current Thread [Next in Thread]