[Freeciv-Dev] (PR#14521) configure check for GTK >= 2.4 should be 2.6 or 2.8

["William Allen Simpson" <wsimpson@xxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=14521 >

./autogen.sh --disable-nls --with-included-gettext --enable-client=gtk2 
--prefix=/freeciv-test

"checking for GTK+ - version >= 2.4.0... yes (version 2.4.9)"

This compiles 2.0.6 correctly on MACOSX using Fink packages.

This same check is in recent (Oct 17) snapshots and (current) svn.

However, now the trunk compile fails at:

diplodlg.c: In function `create_diplomacy_dialog':
diplodlg.c:477: error: `GTK_STOCK_EDIT' undeclared (first use in this function)
diplodlg.c:477: error: (Each undeclared identifier is reported only once
diplodlg.c:477: error: for each function it appears in.)
make[4]: *** [diplodlg.o] Error 1
make[3]: *** [all] Error 2
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2


Googling showed that these are GTK 2.6 features, but the script only
checks for 2.4.  I didn't find any discussion of this in the archive.

The fix is to update the test for 2.6 or 2.8 (I cannot find the test
in configure.ac) or stop using these new features.


[In my case, this meant that I had to change from Fink to DarwinPorts,
which has newer GTK 2.8.  This is a major change/disruption, and it
would have been helpful had the documentation and scripts told me
_before_ I started!]

"checking for GTK+ - version >= 2.4.0... yes (version 2.8.4)"

yeilded successful make.

-- 
William Allen Simpson
     Key fingerprint =  17 40 5E 67 15 6F 31 26  DD 0D B9 9B 6A 15 2C 32