[Freeciv-Dev] Re: (PR#14520) Darwin tech sequence

["Mateusz Stefek" <mstefek@xxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=14520 >

Dnia 2005-11-01 14:24:11, Christian Knoke napisał(a):
> 
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=14520 >
> 
> 
> SVN HEAD 01 NOV 2005 GTK2
> 
> The PNG shows a little bug, I think. Tech 1 is discovered by Darwin,
> then
> the next tech is automatically chosen and discovered at the same time,
> because bulbs were fulfilled, then Tech 2 is discovered, and then
> another
> science is targeted.
> 
> I think this is what happened here.

Actually the Theory of Gravity was discovered after Amphibious Warfare.  
Freelog()'s were just called in different orders.
What you want to happen here is that you get Tacticts and Amphibious  
Warfare for free and after that you expect your target to be A_UNSET  
and all bulbs to be saved.
The patch is attached. Finally I know what that !was_discovery was for:  
it was wrong.

> The automatically chosen tech is *not* on the way to the tech goal
> set.
> Also, the Darwin Techs should be immediately subsequent, I think.
> 
> Christian
--
mateusz

Index: server/techtools.c
===================================================================
--- server/techtools.c  (wersja 11206)
+++ server/techtools.c  (kopia robocza)
@@ -354,7 +354,7 @@
                       get_tech_name(plr, research->researching),
                       get_tech_name(plr, research->tech_goal));
     } else {
-      if (plr->ai.control || !was_discovery) {
+      if (plr->ai.control) {
         choose_random_tech(plr);
       } else if (is_future_tech(tech_found)) {
         /* Continue researching future tech. */