[Freeciv-Dev] Re: [FreeCiv-Cvs] matusik: Destroy diplomat dialog when the diplomat i...

[Jason Dorje Short <jdorje@xxxxxxxxxxxx>]

freeciv@xxxxxxxxxxxxxxxxxxx wrote:
> This is an automated notification of a change to freeciv cvs, 
> on Thu Oct  6 10:15:04 PDT 2005 = Thu Oct  6 17:15:04 2005 (GMT)
> by Mateusz Stefek <mstefek@xxxxxxxxx>
>
> ---- Files affected:
>
> freeciv/client control.c packhand.c
> freeciv/client/gui-gtk-2.0 diplomat_dialog.c Makefile.am dialogs.c dialogs.h
> freeciv/client/include dialogs_g.h
>
> ---- Log message:
>       Tag: HEAD
>
> Destroy diplomat dialog when the diplomat is killed. The diplomat dialog code 
> is moved to a new file. Patch by me in PR#14062
I'm quite in favor of splitting up dialogs.c.  IMO we should split it 
all up and have one file per dialog...with consistent naming...etc.
Anyway, my point is we should have separate headers too. 
diplomat_dialog.c -> diplomat_dialog_g.h.  But maybe the file name isn't 
right and it should be diplodlg.c (to go with repodlg.c and citydlg.c etc.).
-jason