Complete.Org: Mailing Lists: Archives: freeciv-dev: October 2005:
[Freeciv-Dev] Re: [FreeCiv-Cvs] matusik: Destroy diplomat dialog when th
Home

[Freeciv-Dev] Re: [FreeCiv-Cvs] matusik: Destroy diplomat dialog when th

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Freeciv-Dev <freeciv-dev@xxxxxxxxxxx>
Subject: [Freeciv-Dev] Re: [FreeCiv-Cvs] matusik: Destroy diplomat dialog when the diplomat i...
From: Daniel Markstedt <himasaram@xxxxxxxx>
Date: Thu, 6 Oct 2005 19:56:33 +0200

On 2005-10-06, at 19.21, freeciv@xxxxxxxxxxxxxxxxxxx wrote:

This is an automated notification of a change to freeciv cvs,
on Thu Oct  6 10:15:04 PDT 2005 = Thu Oct  6 17:15:04 2005 (GMT)
by Mateusz Stefek <mstefek@xxxxxxxxx>

---- Files affected:

freeciv/client control.c packhand.c
freeciv/client/gui-gtk-2.0 diplomat_dialog.c Makefile.am dialogs.c dialogs.h
freeciv/client/include dialogs_g.h

---- Log message:
      Tag: HEAD

Destroy diplomat dialog when the diplomat is killed. The diplomat dialog code is moved to a new file. Patch by me in PR#14062


Good work, ironing out these small but nevertheless significant inconsistencies!

There's another dialog that I feel needs to be destroyed at a certain moment: The diplomacy dialog upon end of turn.

An agreement that only one part has agreed on, can be "saved" and signed by the other player much later under perhaps totally different circumstances. This is especially true with AI players who never close a diplomacy dialog on their own.

Daniel




[Prev in Thread] Current Thread [Next in Thread]