Complete.Org: Mailing Lists: Archives: freeciv-dev: September 2005:
[Freeciv-Dev] Re: (PR#13947) tile output in tile popup
Home

[Freeciv-Dev] Re: (PR#13947) tile output in tile popup

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
Subject: [Freeciv-Dev] Re: (PR#13947) tile output in tile popup
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Tue, 13 Sep 2005 08:12:24 -0700
Reply-to: bugs@xxxxxxxxxxx

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13947 >

Benoit Hudson wrote:
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=13947 >
> 
> Does this patch fix it?  Basically, makes the tile output that we
> display be based on the city that's using that tile.  I didn't check
> to make sure it actualy worked or anything -- in particular, I didn't
> audit uses of get_tile_output.  If this patch is bad, then maybe we
> should be using base_get_tile_output instead.

This surely fixes it but with all the other users of get_output_tile 
(OK, I don't actually know which ones) a change to common is probably 
too severe.  Rather we should change the client caller to use 
city_get_output_tile directly.

-jason





[Prev in Thread] Current Thread [Next in Thread]