Complete.Org: Mailing Lists: Archives: freeciv-dev: September 2005:
[Freeciv-Dev] Re: (PR#13947) tile output in tile popup
Home

[Freeciv-Dev] Re: (PR#13947) tile output in tile popup

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: jdorje@xxxxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#13947) tile output in tile popup
From: "Benoit Hudson" <benoit.hudson@xxxxxxxxx>
Date: Tue, 13 Sep 2005 20:45:08 -0700
Reply-to: bugs@xxxxxxxxxxx

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13947 >

> This surely fixes it but with all the other users of get_output_tile
> (OK, I don't actually know which ones) a change to common is probably
> too severe.  Rather we should change the client caller to use
> city_get_output_tile directly.

Just checked.   All the users of get_output_tile are in client/,
except for server/generator/startpos.c

As far as I can tell, the client/ callers should be getting the value
for the city; the generator code is activated before any cities are
created, so the change is neutral anyway.

I find the name odd: shouldn't it be get_tile_output ?  But
regardless, with this few callers, none of which need to be fixed, I
think changing the API is the best solution.

-- Benoît





[Prev in Thread] Current Thread [Next in Thread]