[Freeciv-Dev] Re: (PR#13606) gui-win32: fix compilation
[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13606 >
James Canete wrote:
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=13606 >
>
> gui-win32 broke big time due to a couple patches. I usually fix and
> commit directly, but in this case the amount of changes warrant some
> peer review. :)
>
> This patch gets things working on my end, but I'm not sure if I've fixed
> everything properly. Comments, anyone?
At a glance it looks good.
One comment, I removed the wid code from the client-common and moved it
into gui-win32/wldlg.c (the only user). But is this code really needed?
What use does it provide over special-casing worklists versus
production (which it seems you'd have to do anyway)?
-jason
- [Freeciv-Dev] Re: (PR#13606) gui-win32: fix compilation,
Jason Short <=
|
|