[Freeciv-Dev] Re: (PR#13530) Errors in the help in CVS

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13530 >

Matz wrote:
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=13530 >
> 
> CVS 2005-07-24 gtk2
> 
> The help for wonders doesn't show the required tech. The button is empty. 
> Clicking on the button opens the help for space race.
> The help for the technologies doesn't show allowed the allowed wonders either.
> 
> If you open the help for a city improvement which has no requirement 
> (Baracks, Coinage) the requirement of the last opened improvement will be 
> shown.
> 
> The help for technologies doesn't show correctly which improvements can be 
> build. e.g. the help for communism says "Allows Bank", but the help for 
> banking shows no buildings.
> 
> These errors are only in the help. The game seems to behave correctly.
> I used the default ruleset.

Thanks for the report.  This patch should fix it.

-jason

Index: client/gui-gtk-2.0/helpdlg.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/client/gui-gtk-2.0/helpdlg.c,v
retrieving revision 1.57
diff -p -u -r1.57 helpdlg.c
--- client/gui-gtk-2.0/helpdlg.c        24 Jul 2005 17:01:35 -0000      1.57
+++ client/gui-gtk-2.0/helpdlg.c        26 Jul 2005 02:48:08 -0000
@@ -968,7 +968,7 @@ static void help_update_tech(const struc
       gtk_container_add(GTK_CONTAINER(help_vbox), hbox);
       w = gtk_label_new(_("Allows"));
       gtk_box_pack_start(GTK_BOX(hbox), w, FALSE, FALSE, 0);
-      w = help_slink_new(get_unit_type(j)->name, HELP_UNIT);
+      w = help_slink_new(punittype->name, HELP_UNIT);
       gtk_box_pack_start(GTK_BOX(hbox), w, FALSE, FALSE, 0);
       gtk_widget_show_all(hbox);
     } unit_type_iterate_end;