[Freeciv-Dev] (PR#13543) generic_city_refresh not called

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13543 >

Define the CITY_DEBUGGING macro in city.c (near the top) and run an
autogame.  Eventually the assertion will fail.  This crash is from
current cvs with the attached autogame.

The problem is surely that generic_city_refresh (which rebuilds the
cache) is not being called.

(gdb) bt
#0  0xb7e6383b in raise () from /lib/tls/libc.so.6
#1  0xb7e64fa2 in abort () from /lib/tls/libc.so.6
#2  0xb7e5d2df in __assert_fail () from /lib/tls/libc.so.6
#3  0x080abb38 in get_citizen_output (pcity=0x87bff28, output=0xbffff5a0)
    at city.c:1546
#4  0x080f5817 in city_want (pplayer=0x826fed0, acity=0x87bff28,
ai=0x823ad70)
    at aicity.c:143
#5  0x080f5744 in base_want (pplayer=0x826fed0, pcity=0x87bff28, id=40)
    at aicity.c:208
#6  0x080f5a8d in adjust_building_want_by_effects (pcity=0x87bff28, id=40)
    at aicity.c:262
#7  0x080f6fd6 in ai_manage_buildings (pplayer=0x826fed0) at aicity.c:842
#8  0x080f7d5f in ai_manage_cities (pplayer=0x826fed0) at aicity.c:1231
#9  0x080fd3c5 in ai_do_last_activities (pplayer=0x826fed0) at aihand.c:451
#10 0x0804fee8 in end_phase () at srv_main.c:627
#11 0x08051abc in main_loop () at srv_main.c:1634
#12 0x08052164 in srv_loop () at srv_main.c:1885
#13 0x08051cbc in srv_main () at srv_main.c:1712
#14 0x0804ad04 in main (argc=3, argv=0xbffff934) at civserver.c:242
(gdb) p game.info.turn
$1 = 35
(gdb) p game.info.year
$2 = -2250

set timeout -1

set generator 3

#set steepness 0
#set wetness 0
#set temperature 0

#set topology 3
#set alltemperate 1

#set mapseed 599833218
#set gameseed 1098898863

set aifill 5
hard
set endyear -2000

set saveturns 1
set compresstype 2

set mapseed 23456
set gameseed 34567

#load ~/civgame+1780.sav.gz
#set endyear 1782

#set onsetbarb -4000
#set barb 16

#rulesetdir civ1
#rulesetdir civ2
#rulesetdir history
#rulesetdir default
#rulesetdir history
#quit

start
#help topology