[Freeciv-Dev] (PR#13522) cvs borked by last commit

["Per I. Mathisen" <per@xxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13522 >

Two issues...

Index: ai/aitools.h
===================================================================
RCS file: /home/freeciv/CVS/freeciv/ai/aitools.h,v
retrieving revision 1.57
diff -u -r1.57 aitools.h
--- ai/aitools.h        22 Jul 2005 16:18:04 -0000      1.57
+++ ai/aitools.h        23 Jul 2005 23:33:56 -0000
@@ -32,7 +32,7 @@
 #ifdef DEBUG
 #define CHECK_UNIT(punit)                                                   \
   (assert(punit != NULL),                                                  \
-   assert(punit->type < U_LAST),                                           \
+   assert(punit->type != NULL),                                                
    \
    assert(punit->owner != NULL),                                           \
    assert(&game.players[punit->owner->player_no] == punit->owner),         \
    assert(find_unit_by_id(punit->id) != NULL))

and

barbarian.c: In function 'summon_barbarians':
barbarian.c:369: warning: 'unit' may be used uninitialized in this function
make[3]: *** [barbarian.o] Error 1

The latter looks serious, but I am not sure what is intended.

  - Per